change endpoint config into setup block style#299
Open
slapers wants to merge 2 commits intogermsvel:mainfrom
Open
change endpoint config into setup block style#299slapers wants to merge 2 commits intogermsvel:mainfrom
slapers wants to merge 2 commits intogermsvel:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I hope you don't mind me just opening a PR without any discussions on this. But this PR gives another option of handling the @endpoint config.
I think this PR is very close to the #231 but I decided to put the phoenix_endpoint in the conn private assigns, this way It can be configured in the setup block.
In the PR I removed the config entirely, but its trivial to add it again to keep it backwards compatible.