Skip to content

Comments

feat: add support for phx-change event on input#280

Merged
germsvel merged 1 commit intogermsvel:mainfrom
StephanH90:feat-phx-change-for-input
Jan 24, 2026
Merged

feat: add support for phx-change event on input#280
germsvel merged 1 commit intogermsvel:mainfrom
StephanH90:feat-phx-change-for-input

Conversation

@StephanH90
Copy link
Contributor

Currently, phx-change only works on form elements. This PR adds the functionality to also test this on inputs.

Copy link
Owner

@germsvel germsvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work @StephanH90! 🎉

A quick follow up question. This is something we would also want to support for checkboxes and radio buttons, right?

It doesn't have to be done as part of this PR (we can open an issue for the others), but I just want to make sure so we can have consistent behavior across inputs.

@StephanH90
Copy link
Contributor Author

Yes, I think you are right. It's up to you if you want me to do it as part of this PR as separate commits (then the title would be fitting, now the title is incorrect) or as separate PRs.

@germsvel
Copy link
Owner

@StephanH90 I think we can get this merged in without the rest. And then we can work on the rest (once CI passes).

If you're up for adding support for checkboxes and radio buttons in a separate PR, that would be amazing. But if not, we can add an open issue and see if someone else has time to grab it.

@StephanH90 StephanH90 force-pushed the feat-phx-change-for-input branch 3 times, most recently from 47378d6 to 974a181 Compare January 13, 2026 11:45
@StephanH90
Copy link
Contributor Author

StephanH90 commented Jan 13, 2026

@germsvel I added support for radios, checkboxes and selects as well and added corresponding tests.

@StephanH90 StephanH90 force-pushed the feat-phx-change-for-input branch from 974a181 to 54b47fe Compare January 13, 2026 11:53
@germsvel germsvel merged commit 7fda723 into germsvel:main Jan 24, 2026
2 checks passed
@germsvel
Copy link
Owner

Thanks so much @StephanH90! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants