Add PhoenixTest.reload_page/1 helper#275
Conversation
germsvel
left a comment
There was a problem hiding this comment.
I haven't needed this, but I can see how it can be helpful. I would love to add it.
What do you think about changing the name to reload_page?
I think "reload" is a more common term (at least, I was looking around and that seems to be more common):
Chrome DevTools Protocol👇
My browser reload tooltip 👇
And I would say let's just name it reload, but depending on where you are in the pipeline, it might not be clear what you're reloading.
Some of our other actions have the some tag name alongside it click_link, click_button... hence my thoughts landing on reload_page.
What do you think? Any reason I'm missing why we'd want to call it refresh (or maybe reload) instead of reload_page?
|
I agree with your reasoning, |
|
Thanks @ftes! Finally resolved those conflicts and got this in. 🎉 |
I think this is often helpful to check that some state is persisted, even after a LiveView reloads.