Merge pull request #12 from gerlero/fix-gh-11

Make defensive copies of Interpolator input vectors
gerlero · Jan 28, 2022 · 3b33c3b · 3b33c3b
2 parents 684b274 + e56c85d
commit 3b33c3b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/PCHIPInterpolation.jl b/src/PCHIPInterpolation.jl
@@ -23,7 +23,7 @@ struct Interpolator{Xs,Ys,Ds}
         end
 
         ds = _initial_ds_scipy(xs, ys)
-        new{typeof(xs),typeof(ys),typeof(ds)}(xs, ys, ds)
+        new{typeof(xs),typeof(ys),typeof(ds)}(deepcopy(xs), deepcopy(ys), ds)
     end
 end
 

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -142,3 +142,12 @@ itp = Interpolator(x, x)
 x = collect(range(0, stop=1, length=1000))
 itp = Interpolator(x, x)
 @test itp(1) == 1
+
+# Regression test for https://github.com/gerlero/PCHIPInterpolation.jl/issues/11
+v = [1, 2, 3]
+p = Interpolator(v, v)
+xs = copy(p.xs)
+ys = copy(p.ys)
+v .= -1
+@test p.xs == xs
+@test p.ys == ys