Repository navigation
fix(server): share JJ caches between workflow and review - #1
Open
omarshaarawi wants to merge 2 commits into
Open
omarshaarawi wants to merge 2 commits into
omarshaarawi wants to merge 2 commits into
Conversation
github-actions
Bot
added
vouch:unvouched
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JJ workflow and VCS registry construct separate drivers, so workflow cache invalidation leaves review metadata stale. After a remote rename, a warmed registry-backed review can return an empty diff even though the workflow driver resolves the new remote correctly.
The registry now consumes the existing JJ service. Both paths use the same exported Effect layer and share its caches. The regression uses a real JJ repository to warm a review diff, rename its remote, invalidate caches through the service, and verify the registered driver still reports the changed file and correct base.
Verified with JJ 0.44.0. The regression failed before the fix and passes after it. All eight tests in
VcsDriverRegistry.test.ts, the server typecheck, and lint and formatting checks for the two changed files pass.Implemented with GPT-6 Astra. Reviewed and integrated with GPT-6.1 Sol and GPT-6 Sol through the Codex harness in T3 Code.