Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout number inputs broken #160

Closed
2 tasks done
paulgirard opened this issue Jun 12, 2024 · 2 comments
Closed
2 tasks done

Layout number inputs broken #160

paulgirard opened this issue Jun 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@paulgirard
Copy link
Collaborator

paulgirard commented Jun 12, 2024

for slow down and edge influence inputs (check others):

  • input dose not accept float value (hit enter shows a invalid message)
  • step should be 0.1
@paulgirard paulgirard added the bug Something isn't working label Jun 12, 2024
@sim51
Copy link
Collaborator

sim51 commented Jun 18, 2024

If I put a float number with a coma instead of a point (ex: 1,6 instead of 1.6), I have no error and I can't start the layout.
The start button is not disable, I can click on it, but nothing happened

BTW, to see the modifications, I had to click on "Reset application state" button

sim51 added a commit that referenced this issue Jun 18, 2024
- fix boolean value by using the defaultValue instead of the checked
  attribute (see facebook/react#3005)
- notify an error if some params are wrong
@sim51
Copy link
Collaborator

sim51 commented Jun 18, 2024

I also found an error on boolean input. I fixed it.
To reproduce it, just click on the Guess setting button two times. The strong gravity mode is then disabled ...

Due to the remove of the form validation, now we can send bad data (like the 1,6 in my previous comment).
I added a try/catch and notify of the error when you start a layout. So even if we don't prevent the layout to stat, the user will have a feedback that there is something wrong. And the graphology error are really good : "graphology-layout-forceatlas2/worker: the edgeWeightInfluence setting should be a number."

@sim51 sim51 closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants