-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code quality #76
Improve code quality #76
Conversation
bd16465
to
1c0bd84
Compare
@scivision, the pull request is ready. |
5e765a7
to
d3bf120
Compare
I cherry-picked individual commits into main until the tests started failing. I then switched back to your branch and rebased on main--still failing tests, but at least consistent with main. |
6246f1e
to
751be8b
Compare
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 90.21% 90.74% +0.52%
==========================================
Files 40 41 +1
Lines 2003 2236 +233
Branches 178 189 +11
==========================================
+ Hits 1807 2029 +222
- Misses 144 157 +13
+ Partials 52 50 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@scivision, |
ab63e51
to
343a786
Compare
Improve Code Quality
Improve typing
mypy
strict modepy.typed
to enable typing (c.f. Would adding py.typed suffice to add mypy support ? #73, PEP 561 compliant)pre-commit
ruff
configuration for the new releaseBadges
Add some badges,
Contributing
CONTRIBUTING.md
file to standardise how to set uppymap3d
to contributepre-commit
CI