-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#195: Initial implementation of read-only LDAP User and UserGroup DAOs #197
Conversation
*/ | ||
@Override | ||
public User merge(User entity) { | ||
// DO NOTHING: PERSITENCE IS NOT SUPPORTED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Theoretically these write operations should fail instead of faking success (rising an exception like "unsupported operation") ? I know this is a safest solution in terms of compatibility, at the expense of the consistency of the operations, Did you already tried?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put execeptions initially, but I had to remove them because persistence was called in some
weird cases, I will check if those are not an issue anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it works also throwing exception, so I did another commit for this
.../persistence/src/main/java/it/geosolutions/geostore/core/dao/ldap/impl/UserGroupDAOImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, another couple of questions:
- Is there some schema of how this works, so we can add it to the wiki ?
- This can be used only "instead of" but not in parallel with other services, right ?
- if yes, it is correct that in case we have to have multiple user services (LDAP+SPID+DB...), we have to come back to old system? The old LDAP integration will be maintained, anyway, right?
- if no: how the ID's conflicts are solved?
…re/dao/ldap/impl/UserGroupDAOImpl.java Co-Authored-By: Lorenzo Natali <offtherailz@gmail.com>
These DAOs can be currently used on an LDAP only environment. We can improve them in the future to support multiple sources |
Enabling these DAOs (see example in xml) users and groups are fetched from LDAP instead of the internal database.
Current support is limited to API calls required by MapStore permissions handling.