-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9208 Timeline map sync does not update for time ranges visualization #9209
Conversation
…anges visualization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should
- move expandLimitSelector default internally if possible
- Check and debug the single point use case to indentify why it works
@offtherailz below test done with master without applying fix from this PR: The layer in this map does not have data.values and the domain contains in this case the rangeData is populated from this app initialization because of the updateRangeDataOnRangeChange epic that update the value for all domain that returns true for isTimeDomainInterval check-getTimeItems.mp4The check |
@offtherailz you forgot to merge this :) @ElenaGallo please test in DEV and let us know if we can backport. Let's spend some more time on what you have reported for the GS issue you have experienced, maybe checking it with someone from the GS team. |
The issue with the bbox capturing two features is due to the WMTS multidimensional using a "BBOX" filter against the database, which in turn is configured for loose bbox filtering: With loose bbox, queries are very fast, but not precise, as a "bbox vs bbox" filter is applied: the second line does not intersects the red search area, but the bbox of the line does, that's why it's returned. How to fix it:
|
Thank you so much for reporting the above @aaime |
Test passed, @allyoucanmap please backport to the stable branch. Thanks |
…anges visualization (geosolutions-it#9209) * Fix geosolutions-it#9208 Timeline map sync does not update for time ranges visualization * move the default expand limit value to selector
Description
This PR improved the get time items selector to use the updated range data if provided
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#9208
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
@tdipisa
It seems there is a problem with the spatial filter of domains, here an example:
The following example shows a DescribeDomains request where we expect to get information of a single feature but instead we get two:
request: https://development.demo.geonode.org/geoserver/gwc/service/wmts?service=WMTS&REQUEST=DescribeDomains&version=1.0.0&layer=geonode:test_time&tileMatrixSet=EPSG:4326&bbox=829991.4716345865,5755211.389189923,1039581.8031925397,5899065.876422625,EPSG:3857&expandLimit=20&time=2022-06-01T00:00:00.000Z/2024-01-09T11:07:53.218Z
response:
Visual representation of bbox param (red) and returned space domain (orange)
Note: We are also applying the bbox param to GetDomainValues and GetHistogram so they could have the same problem