Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9036: Fix - Catalog mode and result retention #9037

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented Mar 17, 2023

Description

This PR fixes the catalog mode and result retention when navigated away from map without closing the catalog panel followed by loading a new map

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

What is the new behavior?

  • The catalog mode is reset to view when panel is unmounted
  • The catalog result is cleared when panel is unmounted. This fixes the invalid result from being loaded when previously loaded result are from a different service

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added bug Internal BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Mar 17, 2023
@dsuren1 dsuren1 added this to the 2023.01.01 milestone Mar 17, 2023
@dsuren1 dsuren1 requested a review from MV88 March 17, 2023 12:21
@dsuren1 dsuren1 self-assigned this Mar 17, 2023
@dsuren1 dsuren1 linked an issue Mar 17, 2023 that may be closed by this pull request
1 task
@MV88 MV88 merged commit bdb8470 into geosolutions-it:master Mar 20, 2023
@ElenaGallo
Copy link
Contributor

Test passed, @dsuren1 please backport this PR to 2023.01.xx. Thanks

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Mar 22, 2023
MV88 pushed a commit that referenced this pull request Mar 23, 2023
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog issue when opening with a service other than the previous map
4 participants