#8740 Move the mouse on 3D Tiles #8748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allyoucanmap
added
bug
BackportNeeded
…into issue_8740
dsuren1
requested changes
Oct 28, 2022
There was a problem hiding this comment.
@allyoucanmap
LGTM
Not sure if this related to this PR. However wanted to highlight. I get this error when traversing the 3d map
dsuren1
approved these changes
Oct 28, 2022
|
@ElenaGallo |
|
Test passed on DEV. @dsuren1 please backport. Thanks. |
allyoucanmap
added a commit
to allyoucanmap/MapStore2
that referenced
this pull request
Nov 3, 2022
* fix drill pick on 3D model * add test
allyoucanmap
removed
the
BackportNeeded
dsuren1
pushed a commit
that referenced
this pull request
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently queryable false is available only on WFS and for this reason if was failing on top of 3D tiles because they are not inside an entity collection. This PR adds the queryable property also on Vector layer and improve the filter of drillPick
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#8740
What is the new behavior?
The application does not return an error in console and the 3D tiles are queryable again
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information