Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2022.02.xx] #8491 linter for markdown files #8737

Merged
merged 2 commits into from
Oct 27, 2022
Merged

[Backport 2022.02.xx] #8491 linter for markdown files #8737

merged 2 commits into from
Oct 27, 2022

Conversation

belom88
Copy link
Contributor

@belom88 belom88 commented Oct 27, 2022

#8491 linter for markdown files

@belom88 @MV88
* geosolutions-it#8491 linter for markdown files
a751b05 
* fix code style

* Update package.json

Co-authored-by: Matteo V <matteo.velludini@geosolutionsgroup.com>
@belom88 belom88 requested a review from tdipisa October 27, 2022 08:23
@belom88 belom88 self-assigned this Oct 27, 2022
@tdipisa tdipisa requested review from MV88 and removed request for tdipisa October 27, 2022 08:32
@tdipisa tdipisa added this to the 2022.02.01 milestone Oct 27, 2022
@MV88 MV88 changed the title [Backport 2022.01.xx] #8491 linter for markdown files [Backport 2022.02.xx] #8491 linter for markdown files Oct 27, 2022
MV88
MV88 requested changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@MV88 MV88 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some files are missing since in the original pr files changed were 63

keycloak for example it not included
image

please @belom88 can you find the missing files and add them to the pr ?

@MV88
Copy link
Contributor

MV88 commented Oct 27, 2022

@belom88 also please check here why the build is failing

@belom88
Copy link
Contributor Author

belom88 commented Oct 27, 2022

Sorry, I forgot 1 trailing space. The good news - we've tested it

@MV88
Copy link
Contributor

MV88 commented Oct 27, 2022

some files are missing since in the original pr files changed were 63

keycloak for example it not included image

please @belom88 can you find the missing files and add them to the pr ?

@belom88 hi, have you missed this comment?

@belom88
Copy link
Contributor Author

belom88 commented Oct 27, 2022

some files are missing since in the original pr files changed were 63
keycloak for example it not included image
please @belom88 can you find the missing files and add them to the pr ?

@belom88 hi, have you missed this comment?

3 files were with conflict:

  • docs/developer-guide/integrations/users/keycloak.md
  • docs/user-guide/widgets.md
  • docs/developer-guide/maps-configuration.md

Files not presented in the backport:

  • docs/developer-guide/documentation-guidelines.md
  • docs/developer-guide/integrations/users/keycloak.md
  • docs/user-guide/widgets.md

The content of these files is different from master and doesn't have linter issues

@MV88
Copy link
Contributor

MV88 commented Oct 27, 2022

The content of these files is different from master and doesn't have linter issues

fair enough, thanks for the check. approving

@MV88 MV88 merged commit 448273c into geosolutions-it:2022.02.xx Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MV88 MV88 MV88 approved these changes

Assignees

@belom88 belom88

Labels
Backport Documentation Internal Priority: Medium
Projects
None yet
Milestone
2022.02.01
Development

Successfully merging this pull request may close these issues.
3 participants
@belom88 @MV88 @tdipisa