#8588: Fix - Effective handle of widget conversion #8721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
allyoucanmap
approved these changes
Oct 21, 2022
|
@ElenaGallo please test this in DEV and let us know for the overall backport for PRs connected to #8588. This should cover also #8722 |
dsuren1
added a commit
to dsuren1/MapStore2
that referenced
this pull request
Nov 3, 2022
…osolutions-it#8721) (cherry picked from commit 99132d4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes initiation of widget conversion based on widgetconfig data from some old and empty maps
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#8588
What is the new behavior?
All these maps loads fine
https://dev-mapstore.geosolutionsgroup.com/mapstore/#/viewer/openlayers/10358 (With widget)
https://dev-mapstore.geosolutionsgroup.com/mapstore/#/viewer/openlayers/new (No widgetconfig)
https://dev-mapstore.geosolutionsgroup.com/mapstore/#/viewer/openlayers/40249 (Widgetconfig with empty obj)
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
Should fix also #8722