Implemented Feature Editor Plugin #2064

offtherailz · 2017-07-27T11:29:20Z

Extended DrawSupport to edit existing Geometries (leaflet and OpenLayers). Fix Extend drawsupport for editing #1819
Replaces agGrid with react-data-grid (moved old to FeatureGrid_ag). Fix replace agGrid with react-data-grid #1812
Implementation of FeatureEditor plugin. Fix Support for Editing #1102
Added support for editing/drowing features. Fix Connect drawsupport with feature grid #2038
Finalized support for WFST. Fix Support for WFS-T #1885

We should evaluate to:

Replace the hold grid example with the new grid
Hide unwanted tools in edit mode as in the mockup

Other minor fixes:

Opacity changes does not refresh the whole layer now. Fix Layer opacity setting in Leaflet #2063
Now only a request is performed (2 only if a "wfs natural order missing primary key" error is detected). Fix Query panel issues two identical requests on search. #2043

* Replaces agGrid with react-data-grid (moved to FeatureGrid_ag) * Implementation of FeatureEditor plugin

coveralls · 2017-07-27T11:46:28Z

Coverage decreased (-0.1%) to 79.832% when pulling 8777146 on offtherailz:featureeditor into 008969b on geosolutions-it:master.

MV88 · 2017-07-27T12:21:16Z

package.json

@@ -131,6 +132,7 @@
    "react-container-dimensions": "1.3.2",
    "react-copy-to-clipboard": "5.0.0",
    "react-data-grid": "2.0.41",
+    "react-data-grid-addons": "^2.0.49",
    "react-dnd": "2.4.0",


I think we can remove react-data-grid-addons at all. It is not used anymore.

mbarto · 2017-07-27T12:45:42Z

web/client/selectors/maptype.js

@@ -22,8 +22,12 @@ const mapTypeSelector = (state) => state && state.maptype && state.maptype.mapTy
 * @return {boolean}
 */
 const isCesium = state => mapTypeSelector(state) === "cesium";
+const isLeaflet = state => mapTypeSelector(state) === "leaflet";


Where are you using this?

it is not used anymore, but i think it can be useful in the future. But i can understand your point.

I would replace all 3 with a generic is('<maptype')

coveralls · 2017-07-27T14:45:14Z

Coverage increased (+0.2%) to 80.141% when pulling 9372135 on offtherailz:featureeditor into 008969b on geosolutions-it:master.

mbarto

The FeatureGrid example does not work anymore

mbarto

After the query builder is open, the DrawerMenu cannot be closed anymore

… featureeditor

* added tests * highlight generalized * improved drawermenu actions flows

mbarto · 2017-07-28T10:31:33Z

web/client/components/data/featuregrid/FeatureGrid.jsx

-    static contextTypes = {
-        messages: PropTypes.object
+    static childContextTypes = {
+        isModified: React.PropTypes.func,


use PropTypes, not React.PropTypes

good catch!

mbarto · 2017-07-28T10:35:18Z

web/client/components/data/featuregrid/editors/NumberEditor.jsx

+    };
+    constructor(props) {
+        super(props);
+        this.validate = (value) => {


You can also take this methods definitions out of the constructor and remove it

It was my first attempt, but it didn't worked. Probably because it is a derived class.

mbarto · 2017-07-28T10:44:39Z

web/client/components/map/leaflet/DrawSupport.jsx

@@ -125,40 +189,43 @@ class DrawSupport extends React.Component {
            }
        });
        this.props.map.addLayer(vector);
-        // Immidiatly draw passed features
+        // Immediatly draw passed features


Immediately :-)

yep, it was a partial fix.. o(ò ò)o

coveralls · 2017-07-28T14:14:35Z

Coverage increased (+0.5%) to 80.39% when pulling d193db5 on offtherailz:featureeditor into 03a92db on geosolutions-it:master.

coveralls · 2017-07-28T14:35:41Z

Coverage increased (+0.5%) to 80.39% when pulling f6ac6f2 on offtherailz:featureeditor into 03a92db on geosolutions-it:master.

coveralls · 2017-07-31T10:31:17Z

Coverage increased (+0.4%) to 80.381% when pulling 4c565b6 on offtherailz:featureeditor into 03a92db on geosolutions-it:master.

coveralls · 2017-07-31T14:13:37Z

Coverage increased (+0.5%) to 80.389% when pulling 3de53b6 on offtherailz:featureeditor into 03a92db on geosolutions-it:master.

* Added new styles on feature grid * Fix webpack

coveralls · 2017-07-31T14:37:59Z

Coverage increased (+0.4%) to 80.381% when pulling 4e5711f on offtherailz:featureeditor into 03a92db on geosolutions-it:master.

coveralls · 2017-07-31T14:57:19Z

Coverage increased (+0.5%) to 80.389% when pulling 4e5711f on offtherailz:featureeditor into 03a92db on geosolutions-it:master.

Implemented Feature Editor Plugin

8777146

* Replaces agGrid with react-data-grid (moved to FeatureGrid_ag) * Implementation of FeatureEditor plugin

MV88 requested changes Jul 27, 2017

View reviewed changes

mbarto reviewed Jul 27, 2017

View reviewed changes

added test for leaflet drawsupport

9372135

geosolutions-it deleted a comment from offtherailz Jul 28, 2017

mbarto suggested changes Jul 28, 2017

View reviewed changes

offtherailz and others added 3 commits July 28, 2017 11:18

minor fixes on grid editor.

a9f326e

removed unused import. Fixed grid example

5f2082f

Merge branch 'master' into featureeditor

e9d24c7

mbarto suggested changes Jul 28, 2017

View reviewed changes

Merge branch 'featureeditor' of github.com:offtherailz/MapStore2 into…

4203bf7

… featureeditor

geosolutions-it deleted a comment Jul 28, 2017

Highlight minor fixes and improvements (#23)

592b78c

* added tests * highlight generalized * improved drawermenu actions flows

geosolutions-it deleted a comment Jul 28, 2017

mbarto suggested changes Jul 28, 2017

View reviewed changes

offtherailz added 2 commits July 28, 2017 15:56

improvements to example. Fixes to the tests

d193db5

minor typos and other fixes

f6ac6f2

geosolutions-it deleted a comment Jul 28, 2017

mbarto approved these changes Jul 28, 2017

View reviewed changes

geosolutions-it deleted a comment Jul 28, 2017

offtherailz added 2 commits July 31, 2017 12:09

improved action names and reduced epics complexity

bf0531d

disable plugins in edit mode

4c565b6

geosolutions-it deleted a comment Jul 31, 2017

updated example with editable data

3de53b6

geosolutions-it deleted a comment Jul 31, 2017

Added new styles on feature grid (#24)

c2a40be

* Added new styles on feature grid * Fix webpack

geosolutions-it deleted a comment Jul 31, 2017

MV88 approved these changes Jul 31, 2017

View reviewed changes

fixed example zoom level

4e5711f

offtherailz merged commit a981157 into geosolutions-it:master Jul 31, 2017

offtherailz deleted the featureeditor branch February 18, 2020 11:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented Feature Editor Plugin #2064

Implemented Feature Editor Plugin #2064

offtherailz commented Jul 27, 2017 •

edited

Loading

coveralls commented Jul 27, 2017 •

edited

Loading

MV88 Jul 27, 2017

offtherailz Jul 27, 2017

mbarto Jul 27, 2017

MV88 Jul 27, 2017

mbarto Jul 28, 2017

coveralls commented Jul 27, 2017

mbarto left a comment

mbarto left a comment

mbarto Jul 28, 2017

offtherailz Jul 28, 2017

mbarto Jul 28, 2017

offtherailz Jul 28, 2017

mbarto Jul 28, 2017

MV88 Jul 28, 2017

coveralls commented Jul 28, 2017

coveralls commented Jul 28, 2017

coveralls commented Jul 31, 2017

coveralls commented Jul 31, 2017

coveralls commented Jul 31, 2017

coveralls commented Jul 31, 2017

Implemented Feature Editor Plugin #2064

Implemented Feature Editor Plugin #2064

Conversation

offtherailz commented Jul 27, 2017 • edited Loading

coveralls commented Jul 27, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jul 27, 2017

mbarto left a comment

Choose a reason for hiding this comment

mbarto left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jul 28, 2017

coveralls commented Jul 28, 2017

coveralls commented Jul 31, 2017

coveralls commented Jul 31, 2017

coveralls commented Jul 31, 2017

coveralls commented Jul 31, 2017

offtherailz commented Jul 27, 2017 •

edited

Loading

coveralls commented Jul 27, 2017 •

edited

Loading