Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved background selector #1876

Merged
merged 1 commit into from
May 24, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion web/client/localConfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
{
"name": "BackgroundSelector",
"cfg": {
"bottom": 40,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you use css?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we could, but most probably this change in each installation by plugins presence and so on.
So configure it only in the product is better choice, IMHO.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like using config for css related stuff, but it's not a blocker for me

"dimensions": {
"side": 65,
"sidePreview": 65,
Expand Down Expand Up @@ -126,7 +127,8 @@
}, "Login",
"OmniBar", "BurgerMenu", "Expander", "GlobeViewSwitcher"
],
"desktop": ["Map", "HelpLink", "Share", "DrawerMenu", "Version", "BackgroundSelector", {
"desktop": ["Map", "HelpLink", "Share", "DrawerMenu", "Version", {"name": "BackgroundSelector", "cfg": { "bottom": 40 } },
{
"name": "Identify",
"showIn": ["IdentifyBar", "Settings"],
"cfg": {
Expand Down Expand Up @@ -223,6 +225,7 @@
},{
"name": "BackgroundSelector",
"cfg": {
"bottom": 40,
"dimensions": {
"side": 65,
"sidePreview": 65,
Expand Down