Fixes #1302: current version in the UI #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MV88
requested changes
May 12, 2017
web/client/actions/version.js
Outdated
| @@ -0,0 +1,39 @@ | |||
| /** | |||
| * Copyright 2015, GeoSolutions Sas. | |||
| * All rights reserved. | |||
web/client/plugins/Version.jsx
Outdated
| @@ -0,0 +1,55 @@ | |||
| /* | |||
| * Copyright 2016, GeoSolutions Sas. | |||
| * All rights reserved. | |||
web/client/reducers/version.js
Outdated
| @@ -0,0 +1,26 @@ | |||
| /** | |||
| * Copyright 2017, GeoSolutions Sas. | |||
| * All rights reserved. | |||
MV88
requested changes
May 12, 2017
web/client/actions/version.js
Outdated
| @@ -0,0 +1,39 @@ | |||
| /** | |||
| * Copyright 2015, GeoSolutions Sas. | |||
| * All rights reserved. | |||
web/client/reducers/version.js
Outdated
| /** | ||
| * Copyright 2017, GeoSolutions Sas. | ||
| * All rights reserved. | ||
| * |
Gnafu
reviewed
May 12, 2017
| @@ -192,7 +192,7 @@ | |||
| "react/jsx-uses-vars": 2, // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-uses-vars.md | |||
| "react/no-did-mount-set-state": [2, "allow-in-func"], // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-did-mount-set-state.md | |||
| "react/no-did-update-set-state": 2, // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-did-update-set-state.md | |||
| "react/no-multi-comp": 2, // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-multi-comp.md | |||
| "react/no-multi-comp": 0, // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-multi-comp.md | |||
There was a problem hiding this comment.
I'll use "1", as the warning will not stop the build and we can improve this later
There was a problem hiding this comment.
I think we don't need this warning, this is why I removed it. Opinions?
There was a problem hiding this comment.
I agree, we can ignore this warning
offtherailz
approved these changes
May 12, 2017
MV88
approved these changes
May 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.