Fix #1640 added singleTile option to Display Tab #1803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Store2 into MV88-iss_1640_singletile_fix
mbarto
suggested changes
May 10, 2017
| @@ -79,6 +79,7 @@ function wmsToLeafletOptions(options) { | |||
| transparent: options.transparent !== undefined ? options.transparent : true, | |||
| tiled: options.tiled !== undefined ? options.tiled : true, | |||
| opacity: opacity, | |||
| "zIndex": options.zIndex, | |||
| newLayer = L.tileLayer.multipleUrlWMS(urls, newQueryParameters); | ||
| } | ||
| if ( newParameters.length > 0 ) { | ||
| newParameters.forEach( key => newParams[key] = newQueryParameters[key] ); |
web/client/utils/cesium/Layers.js
Outdated
| @@ -35,9 +35,8 @@ var Layers = { | |||
| updateLayer: function(type, layer, newOptions, oldOptions, map) { | |||
| var layerCreator = layerTypes[type]; | |||
| if (layerCreator && layerCreator.update) { | |||
| return layerCreator.update(layer, newOptions, oldOptions, map); | |||
| return layerCreator.update(newOptions, oldOptions, map); | |||
There was a problem hiding this comment.
You cannot change the signature of update, other layers (e.g. MarkerLayer) expect a layer as the first parameter
offtherailz
approved these changes
May 11, 2017
mbarto
approved these changes
May 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SingleTile option has been added for leaflet and openlayers and cesium in layer properties.
It has been also fixed the tileprovider and wms proxy for cesium.
Cesium Layer has been updated with correct props.