Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #1563 catalog pagination #1568

Merged
merged 2 commits into from
Mar 16, 2017

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Mar 15, 2017

The pageEvent.eventkey was undefined so I used the mousevent

see #1563

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.062% when pulling 0802745 on MV88:iss_1563_catalog_pagination into 139ca28 on geosolutions-it:master.

if (pageEvent && pageEvent.eventKey !== undefined) {
let start = ((pageEvent.eventKey - 1) * this.props.pageSize) + 1;
handlePage(mouseEvent) {
if (mouseEvent) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call it `eventKey

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.062% when pulling 867f75a on MV88:iss_1563_catalog_pagination into 139ca28 on geosolutions-it:master.

@Gnafu
Copy link
Contributor

Gnafu commented Mar 15, 2017

Can you redo the PR on the 2017.02.00 branch? (maybe squashed)

@MV88
Copy link
Contributor Author

MV88 commented Mar 15, 2017

@Gnafu Sure. It was already planned

@offtherailz offtherailz merged commit 9195837 into geosolutions-it:master Mar 16, 2017
MV88 added a commit to MV88/MapStore2 that referenced this pull request Mar 16, 2017
offtherailz pushed a commit that referenced this pull request Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants