Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1144 Feature info allowed options should be a whitelist #1412

Merged
merged 2 commits into from
Jan 30, 2017
Merged

Fix 1144 Feature info allowed options should be a whitelist #1412

merged 2 commits into from
Jan 30, 2017

Conversation

allyoucanmap
Copy link
Contributor

Replaced exclude options with include options on GetFeatureInfo WMS request

@simboss simboss added the ready label Jan 27, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 80.436% when pulling c9bc8c7 on allyoucanmap:excl-to-incl-opt into c811fa0 on geosolutions-it:master.

offtherailz
offtherailz requested changes Jan 27, 2017
View reviewed changes
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "excludeOptions" and "includeOptions" from every configuration.

web/client/localConfig.json
"describeCoverage",
"describeLayer",
"loading"
"includeOptions": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This options should be the defaults, so they should not be present in the localConfig.json, but overridable in this way if needed.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 80.436% when pulling a521d0d on allyoucanmap:excl-to-incl-opt into c811fa0 on geosolutions-it:master.

@offtherailz offtherailz merged commit d70b92b into geosolutions-it:master Jan 30, 2017
@offtherailz offtherailz removed the ready label Jan 30, 2017
@allyoucanmap allyoucanmap deleted the excl-to-incl-opt branch May 19, 2017 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarto mbarto mbarto approved these changes

@offtherailz offtherailz offtherailz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@allyoucanmap @coveralls @offtherailz @mbarto @simboss