Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1326 : Added limits for group name and desc and a message #1396

Merged
merged 3 commits into from
Jan 25, 2017
Merged

fix #1326 : Added limits for group name and desc and a message #1396

merged 3 commits into from
Jan 25, 2017

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Jan 24, 2017 •
edited
Loading

fixed #1326

  • provided a maxLength to the input field
  • provided a localized message when the limit is reached for both the name and the description
  • Header now display a long message correctly if there are some spaces

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 80.514% when pulling 3d39baf on MV88:iss_1326_group_description into 1cf334b on geosolutions-it:master.

mbarto
mbarto suggested changes Jan 25, 2017
View reviewed changes
web/client/components/manager/users/GroupDialog.jsx
@@ -56,6 +57,7 @@ const GroupDialog = React.createClass({
options: {},
useModal: true,
closeGlyph: "",
descLimit: 255,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used. You repeat 255 everywhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to use it but it was undefined and wasn't working

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 80.452% when pulling 757e54d on MV88:iss_1326_group_description into 1cf334b on geosolutions-it:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 80.541% when pulling 5c76350 on MV88:iss_1326_group_description into 1cf334b on geosolutions-it:master.

@MV88 MV88 merged commit e62ba54 into geosolutions-it:master Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarto mbarto mbarto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Groups cannot be created if the entered description is too long
3 participants
@MV88 @coveralls @mbarto