#11779: FIX Setting the map projection freezes MapStore causing OOM if resolutions configured in new.json file with a different projection #11788

mahmoudadel54 · 2025-12-10T14:28:08Z

Description

This PR includes:

prevent OOM by enforcing projection-aware resolutions in new.json file in mapOptions.view
Add strict check: only use configured resolutions if view.projection in new.json file matches target SRS in createView
Eliminates infinite tile loading and out-of-memory crashes when switching to different CRS
fix print file by passing the projection prop with resolutions to gurantee the above check

** the new edits includes -> a projection should be added to resolutions/scales in mapOptions.view in new.json file to be read properly. **

Please check if the PR fulfills these requirements

The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

Issue

What is the current behavior?
#11779

What is the new behavior?

The OOM behavior not happen now if a resolutions and projection provided in new.json file and user switch to different projection rather than the resolutions one.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

Yes, and I documented them in migration notes
No

Other useful information

This new.json for test

{
  "version": 2,
  "map": {
    "projection": "EPSG:900913",
    "units": "m",
    "center": { "x": 1250000.0, "y": 5370000.0, "crs": "EPSG:900913" },
    "zoom": 5,
    "mapOptions": {
      "view": {
        "resolutions": [
          84666.66666666688,
          42333.33333333344,
          21166.66666666672,
          10583.33333333336,
          5291.66666666668,
          2645.83333333334,
          1322.91666666667,
          661.458333333335000,
          529.166666666668000,
          396.875000000001000,
          264.583333333334000,
          132.291666666667000,
          66.145833333333500,
          39.687500000000100,
          26.458333333333400,
          13.229166666666700,
          6.614583333333350,
          3.968750000000010,
          2.645833333333340,
          1.322916666666670,
          0.661458333333335
        ],
        "projection": "EPSG:3857"
      }
    },
    "maxExtent": [-20037508.34, -20037508.34, 20037508.34, 20037508.34],
    "layers": [
      {
        "format": "image/jpeg",
        "group": "background",
        "name": "osm:osm_simple_light",
        "opacity": 1,
        "title": "OSM Simple Light",
        "thumbURL": "product/assets/img/osm-simple-light.jpg",
        "type": "wms",
        "url": [
          "https://maps1.geosolutionsgroup.com/geoserver/wms",
          "https://maps2.geosolutionsgroup.com/geoserver/wms",
          "https://maps3.geosolutionsgroup.com/geoserver/wms",
          "https://maps4.geosolutionsgroup.com/geoserver/wms",
          "https://maps5.geosolutionsgroup.com/geoserver/wms",
          "https://maps6.geosolutionsgroup.com/geoserver/wms"
        ],
        "tileSize": 512,
        "visibility": false,
        "singleTile": false,
        "credits": {
          "title": "OSM Simple Light | Rendering <a href=\"https://www.geo-solutions.it/\">GeoSolutions</a> | Data © <a href=\"http://www.openstreetmap.org/\">OpenStreetMap</a> contributors, <a href=\"http://www.openstreetmap.org/copyright\">ODbL</a>"
        }
      },
      {
        "format": "image/jpeg",
        "group": "background",
        "name": "osm:osm_simple_dark",
        "opacity": 1,
        "title": "OSM Simple Dark",
        "thumbURL": "product/assets/img/osm-simple-dark.jpg",
        "type": "wms",
        "url": [
          "https://maps6.geosolutionsgroup.com/geoserver/wms",
          "https://maps3.geosolutionsgroup.com/geoserver/wms",
          "https://maps1.geosolutionsgroup.com/geoserver/wms",
          "https://maps4.geosolutionsgroup.com/geoserver/wms",
          "https://maps2.geosolutionsgroup.com/geoserver/wms",
          "https://maps5.geosolutionsgroup.com/geoserver/wms"
        ],
        "tileSize": 512,
        "visibility": false,
        "singleTile": false,
        "credits": {
          "title": "OSM Simple Dark | Rendering <a href=\"https://www.geo-solutions.it/\">GeoSolutions</a> | Data © <a href=\"http://www.openstreetmap.org/\">OpenStreetMap</a> contributors, <a href=\"http://www.openstreetmap.org/copyright\">ODbL</a>"
        }
      },
      {
        "format": "image/jpeg",
        "group": "background",
        "name": "osm:osm",
        "opacity": 1,
        "title": "OSM Bright",
        "thumbURL": "product/assets/img/osm-bright.jpg",
        "type": "wms",
        "url": [
          "https://maps1.geosolutionsgroup.com/geoserver/wms",
          "https://maps2.geosolutionsgroup.com/geoserver/wms",
          "https://maps3.geosolutionsgroup.com/geoserver/wms",
          "https://maps4.geosolutionsgroup.com/geoserver/wms",
          "https://maps5.geosolutionsgroup.com/geoserver/wms",
          "https://maps6.geosolutionsgroup.com/geoserver/wms"
        ],
        "tileSize": 512,
        "visibility": true,
        "singleTile": false,
        "credits": {
          "title": "OSM Bright | Rendering <a href=\"https://www.geo-solutions.it/\">GeoSolutions</a> | Data © <a href=\"http://www.openstreetmap.org/\">OpenStreetMap</a> contributors, <a href=\"http://www.openstreetmap.org/copyright\">ODbL</a>"
        }
      },
      {
        "format": "image/jpeg",
        "group": "background",
        "name": "ne:ne-political",
        "opacity": 1,
        "title": "NE Political",
        "thumbURL": "product/assets/img/ne-political.jpg",
        "type": "wms",
        "url": [
          "https://maps1.geosolutionsgroup.com/geoserver/wms",
          "https://maps2.geosolutionsgroup.com/geoserver/wms",
          "https://maps3.geosolutionsgroup.com/geoserver/wms",
          "https://maps4.geosolutionsgroup.com/geoserver/wms",
          "https://maps5.geosolutionsgroup.com/geoserver/wms",
          "https://maps6.geosolutionsgroup.com/geoserver/wms"
        ],
        "tileSize": 512,
        "visibility": false,
        "singleTile": false,
        "credits": {
          "title": "<p></p>\n"
        }
      },
      {
        "format": "image/jpeg",
        "group": "background",
        "name": "s2cloudless:s2cloudless",
        "opacity": 1,
        "title": "Sentinel 2 Cloudless",
        "type": "wms",
        "url": [
          "https://maps1.geosolutionsgroup.com/geoserver/wms",
          "https://maps2.geosolutionsgroup.com/geoserver/wms",
          "https://maps3.geosolutionsgroup.com/geoserver/wms",
          "https://maps4.geosolutionsgroup.com/geoserver/wms",
          "https://maps5.geosolutionsgroup.com/geoserver/wms",
          "https://maps6.geosolutionsgroup.com/geoserver/wms"
        ],
        "tileSize": 512,
        "source": "s2cloudless",
        "singleTile": false,
        "visibility": false
      },
      {
        "type": "osm",
        "title": "Open Street Map",
        "name": "mapnik",
        "source": "osm",
        "group": "background",
        "visibility": false
      },
      {
        "source": "ol",
        "group": "background",
        "title": "Empty Background",
        "fixed": true,
        "type": "empty",
        "visibility": false
      }
    ]
  }
}

I think guides should be added for this edit

tdipisa

@mahmoudadel54 what about old maps having the old configuration? Probably we should at least automatically update the map state at loading time so that the new logic is applied and when the map is saved the new configuration is also persisted. All in a transparent and automated way ensuring also a good backward compatibility. What do you think @MV88? Up to you to review.

MV88

@mahmoudadel54 not much to say, but one thing to be sure

web/client/components/map/openlayers/Map.jsx

tdipisa · 2025-12-12T09:59:22Z

@mahmoudadel54 not much to say, but one thing to be sure

What about #11788 (review) @MV88?

MV88

LGTM

…e if resolutions configured in new.json file with a different projection Description: - prevent OOM by enforcing projection-aware resolutions in new.json file in mapOptions.view - Add strict check: only use configured resolutions if `view.projection` matches target SRS - Eliminates infinite tile loading and out-of-memory crashes when switching to different CRS - fix print file by passing the projection prop with resolutions to gurantee the above check - add unit test

…e if resolutions configured in new.json file with a different projection Description: - edit unit test uses resolutions without projection

…layers/Map.js

…f resolutions configured in new.json file with a different projection (#11788) * #11779: FIX Setting the map projection crashes MapStore if resolutions configured in new.json file with a different projection Description: - prevent OOM by enforcing projection-aware resolutions in new.json file in mapOptions.view - Add strict check: only use configured resolutions if `view.projection` matches target SRS - Eliminates infinite tile loading and out-of-memory crashes when switching to different CRS - fix print file by passing the projection prop with resolutions to gurantee the above check - add unit test * #11779: FIX Setting the map projection crashes MapStore if resolutions configured in new.json file with a different projection Description: - edit unit test uses resolutions without projection * - resolve review comments by editing the order of viewOptions in openlayers/Map.js (cherry picked from commit 4e68715)

github-actions · 2025-12-12T11:49:00Z

Successfully created backport PR for 2025.02.xx:

[Backport 2025.02.xx] #11779: FIX Setting the map projection freezes MapStore causing OOM if resolutions configured in new.json file with a different projection #11815

tdipisa · 2025-12-12T14:08:50Z

@ElenaGallo waiting for you for before merging the backport

tdipisa · 2025-12-12T14:54:48Z

@mahmoudadel54 not much to say, but one thing to be sure

What about #11788 (review) @MV88?

@MV88 I saw you have merged, but can I have an answer to this please?

ElenaGallo · 2025-12-15T09:26:55Z

Test passed, @tdipisa backport can be merged

MV88 · 2025-12-15T10:53:31Z

Test passed, @tdipisa backport can be merged

we have noticed that current implementation might require an additional effort in order to cover all cases, see here #11779 (comment)

i'll revert this

… MapStore causing OOM if resolutions configured in new.json file with a different projection (geosolutions-it#11788)" This reverts commit 4e68715.

…ng OOM if resolutions configured in new.json file with a different projection (#11788)" (#11821) This reverts commit 4e68715.

…e causing OOM if resolutions configured in new.json file with a different projection (geosolutions-it#11788) * geosolutions-it#11779: FIX Setting the map projection crashes MapStore if resolutions configured in new.json file with a different projection Description: - prevent OOM by enforcing projection-aware resolutions in new.json file in mapOptions.view - Add strict check: only use configured resolutions if `view.projection` matches target SRS - Eliminates infinite tile loading and out-of-memory crashes when switching to different CRS - fix print file by passing the projection prop with resolutions to gurantee the above check - add unit test * geosolutions-it#11779: FIX Setting the map projection crashes MapStore if resolutions configured in new.json file with a different projection Description: - edit unit test uses resolutions without projection * - resolve review comments by editing the order of viewOptions in openlayers/Map.js

… MapStore causing OOM if resolutions configured in new.json file with a different projection (geosolutions-it#11788)" (geosolutions-it#11821) This reverts commit 4e68715.

mahmoudadel54 requested a review from tdipisa December 10, 2025 14:28

mahmoudadel54 self-assigned this Dec 10, 2025

mahmoudadel54 added the bug label Dec 10, 2025

mahmoudadel54 linked an issue Dec 10, 2025 that may be closed by this pull request

Setting the map projection crashes MapStore if resolutions configured in new.json file with a different projection #11779

Open

1 task

tdipisa added this to the 2025.02.01 milestone Dec 11, 2025

tdipisa requested a review from MV88 December 11, 2025 11:26

tdipisa modified the milestones: 2025.02.01, 2026.01.00 Dec 11, 2025

tdipisa reviewed Dec 11, 2025

View reviewed changes

tdipisa marked this pull request as ready for review December 11, 2025 14:49

tdipisa assigned MV88 and unassigned mahmoudadel54 Dec 11, 2025

tdipisa added the backport 2025.02.xx label Dec 12, 2025

MV88 requested changes Dec 12, 2025

View reviewed changes

web/client/components/map/openlayers/Map.jsx Outdated Show resolved Hide resolved

mahmoudadel54 requested a review from MV88 December 12, 2025 11:27

MV88 approved these changes Dec 12, 2025

View reviewed changes

mahmoudadel54 added 3 commits December 12, 2025 13:36

geosolutions-it#11779: FIX Setting the map projection crashes MapStor…

fc0103e

…e if resolutions configured in new.json file with a different projection Description: - edit unit test uses resolutions without projection

- resolve review comments by editing the order of viewOptions in open…

49b10c7

…layers/Map.js

mahmoudadel54 force-pushed the issue_11779 branch from a8ab8f3 to 49b10c7 Compare December 12, 2025 11:39

MV88 merged commit 4e68715 into geosolutions-it:master Dec 12, 2025
5 checks passed

github-actions bot mentioned this pull request Dec 12, 2025

[Backport 2025.02.xx] #11779: FIX Setting the map projection freezes MapStore causing OOM if resolutions configured in new.json file with a different projection #11815

Closed

MV88 mentioned this pull request Dec 15, 2025

Revert "#11779: FIX Setting the map projection freezes MapStore causi… #11821

Merged

12 tasks

offtherailz pushed a commit that referenced this pull request Dec 17, 2025

Revert "#11779: FIX Setting the map projection freezes MapStore causi…

f337dbb

…ng OOM if resolutions configured in new.json file with a different projection (#11788)" (#11821) This reverts commit 4e68715.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

#11779: FIX Setting the map projection freezes MapStore causing OOM if resolutions configured in new.json file with a different projection #11788

#11779: FIX Setting the map projection freezes MapStore causing OOM if resolutions configured in new.json file with a different projection #11788

mahmoudadel54 commented Dec 10, 2025

Uh oh!

tdipisa left a comment •

edited

Loading

Uh oh!

MV88 left a comment

Uh oh!

Uh oh!

tdipisa commented Dec 12, 2025

Uh oh!

MV88 left a comment

Uh oh!

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

tdipisa commented Dec 12, 2025

Uh oh!

tdipisa commented Dec 12, 2025

Uh oh!

ElenaGallo commented Dec 15, 2025

Uh oh!

MV88 commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

#11779: FIX Setting the map projection freezes MapStore causing OOM if resolutions configured in new.json file with a different projection #11788

#11779: FIX Setting the map projection freezes MapStore causing OOM if resolutions configured in new.json file with a different projection #11788

Conversation

mahmoudadel54 commented Dec 10, 2025

Description

Issue

Breaking change

Other useful information

Uh oh!

tdipisa left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MV88 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tdipisa commented Dec 12, 2025

Uh oh!

MV88 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

tdipisa commented Dec 12, 2025

Uh oh!

tdipisa commented Dec 12, 2025

Uh oh!

ElenaGallo commented Dec 15, 2025

Uh oh!

MV88 commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tdipisa left a comment •

edited

Loading