Responsiveness updates to the print modal window - issue #804 #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed radio inputs’ margins and made modal window scrollable and it’s width contained inside the main window
mbarto
suggested changes
Oct 19, 2016
| @@ -435,6 +444,8 @@ html, body, #container, .fill { | |||
|
|
|||
| .modal-body { | |||
| background-color: white; | |||
| height: calc(100vh - 190px); | |||
There was a problem hiding this comment.
This makes the dialog height bigger than the original dialog.
There was a problem hiding this comment.
It should be fixed in the latest commit, can you check it again?
Now it shouldn’t become bigger then the original version
mbarto
approved these changes
Oct 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed radio inputs’ margins and made modal window scrollable and it’s width contained inside the main window. For issue #804