fix #1107 added button for deleting layers in simple way #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
saidaipparla
commented
Oct 18, 2016
saidaipparla
commented
mbarto
suggested changes
Oct 18, 2016
| @@ -46,6 +49,7 @@ var DefaultLayer = React.createClass({ | |||
| propertiesChangeHandler: () => {}, | |||
| onToggle: () => {}, | |||
| onSettings: () => {}, | |||
| activateRemoveLayer: true, | |||
There was a problem hiding this comment.
We should configure this as false, like the other tools
| <ConfirmButton key="removelayer" className="clayer_removal_button" | ||
| text={(<Glyphicon glyph="1-close" />)} | ||
| style={{"float": "right", cursor: "pointer", backgroundColor: "transparent", marginRight: 3, padding: 0, outline: "none"}} | ||
| confirming={{text: "Sei sicuro", |
| @@ -133,7 +133,7 @@ describe('test DefaultLayer module component', () => { | |||
| const tool = ReactDOM.findDOMNode(TestUtils.scryRenderedDOMComponentsWithClass(comp, "glyphicon")[1]); | |||
There was a problem hiding this comment.
You need to use a different index here to get the right tool, in this way you are simply skipping all the tests that were done before
| @@ -158,11 +158,11 @@ describe('test DefaultLayer module component', () => { | |||
| const tool = ReactDOM.findDOMNode(TestUtils.scryRenderedDOMComponentsWithClass(comp, "glyphicon")[1]); | |||
| @@ -239,10 +239,10 @@ describe('test DefaultLayer module component', () => { | |||
| expect(tool).toExist(); | |||
mbarto
approved these changes
Oct 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.