Add removeLayer action #1157
Merged
Add removeLayer action #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarto
suggested changes
Oct 17, 2016
| @@ -264,6 +264,23 @@ function layers(state = [], action) { | |||
| groups: newGroups | |||
| }; | |||
| } | |||
| case REMOVE_LAYER: { | |||
| let layer = (state.flat || []).find(obj => obj.id === action.layerId); | |||
There was a problem hiding this comment.
I don't think find is supported by all browsers. You can use filter and lodash head function to get the same result
manisandro
force-pushed
the
remove_layer
branch
from
fda2d61
to
36c4e35
Compare
manisandro
force-pushed
the
remove_layer
branch
from
36c4e35
to
ecd27ba
Compare
manisandro
force-pushed
the
remove_layer
branch
from
ecd27ba
to
2f201fc
Compare
manisandro
force-pushed
the
remove_layer
branch
from
2f201fc
to
28a3182
Compare
manisandro
force-pushed
the
remove_layer
branch
from
28a3182
to
e42dcc7
Compare
mbarto
approved these changes
Oct 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an easy to use removeLayer action complementary to addLayer.