-
Notifications
You must be signed in to change notification settings - Fork 444
Fix #11453 Refactored MapFooter Plugin #11492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #11453 Refactored MapFooter Plugin #11492
Conversation
|
@ElenaGallo please test this enhancement on dev, thanks |
|
@anup39 The Project selector tool is no longer present on a new map |
|
@ElenaGallo I just tested on dev and on stable, the CRS selector tool is visible based on the role of the user (see localConfig.json configuration make this plugin visible only for ADMIN role) |
|
Yes @ElenaGallo I confirm that's the expected behavior by default configuration. Please retest and improve the functional test scenario if necessary.
thank you @allyoucanmap |
|
@ElenaGallo can we finally mark this as accepted for both DEV and QA? The backport is not necessary here. |
|
@allyoucanmap For the Scale selector, on a small screen (e.g., 853×1280 px), the dropdown menu is not fully visible.
|
|
@ElenaGallo from the screenshot it seems you are using the device toolbar that simulate mobile devices. In MapStore you need to refresh the page to ensure it's detecting the correct device and related mobile configuration. After refreshing there isn't the map footer for mobile neither scale select input:
Instead if you are testing on desktop without the device toolbar and shrink the page width to 853px the scale input is correctly visible
A final note, the select input used is the native html select input and it could be rendered differently based on the device used. It seems the device simulation on the browser it's trying to use the default browser select functionality and fit it in the available space based also on the scale percentage applied, e.g.: if you are using 50% is fully visible:
In conclusion I don't think this is a bug because the scale input is not visible in mobile devices |
|
Thank you @allyoucanmap. @ElenaGallo I moved back the issue in test. Please re-test. |
|
Hi @allyoucanmap, In my screenshot, the screen dimensions had already been updated and refer to the size of an iPad or similar device; this is why the scale selector is visible, but not fully displayed.
@tdipisa In this case, can I move the issue to Accepted? |
|
@ElenaGallo Normally in mobile devices the footer doesn't appear at all as expected by the default config. |
|
New issue here: #11703 |






Description
This PR includes refactor of MapFooter Plugins . Its includes the following fixes:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#11453
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information