Skip to content

Conversation

@anup39
Copy link
Member

@anup39 anup39 commented Sep 17, 2025

Description

This PR includes refactor of MapFooter Plugins . Its includes the following fixes:

  • A new MapFooter container placed on the footer containerPosition of the map viewer
  • This container have a relative position covering the 100% of the width while the height will change based on the content
  • Map footer as plugin contains two targets, one on the left and another on the right
  • Existing children plugin (items) are placed in the same position reviewing the style when needed
  • Removed css related to the map to move the bottom as the footer size
  • Remove the bottom margin inside the maplayout
  • Check behavior on small screen device and included a flex wrap layout
  • Fixed the margin bottom for both Timeline , Widgets and WidgetTray Plugins
  • Added test cases for new MapFooter Plugin
  • Updated the migration guide

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Minor changes to existing features

Issue

What is the current behavior?

#11453

What is the new behavior?

Screenshot 2025-09-17 at 17 18 30

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information

@anup39 anup39 added this to the 2025.02.00 milestone Sep 17, 2025
@anup39 anup39 self-assigned this Sep 17, 2025
@anup39 anup39 linked an issue Sep 17, 2025 that may be closed by this pull request
1 task
@allyoucanmap allyoucanmap merged commit b0b4ba1 into geosolutions-it:master Oct 13, 2025
6 checks passed
@allyoucanmap
Copy link
Contributor

@ElenaGallo please test this enhancement on dev, thanks

@ElenaGallo
Copy link
Contributor

@anup39 The Project selector tool is no longer present on a new map

MS DEV - MS version 2025.01.02
sssss

@allyoucanmap
Copy link
Contributor

@ElenaGallo I just tested on dev and on stable, the CRS selector tool is visible based on the role of the user (see localConfig.json configuration make this plugin visible only for ADMIN role)
Both dev and stable have the same behavior from my tests, could you please confirm the user roles used in the two screenshot #11492 (comment)?

@tdipisa
Copy link
Member

tdipisa commented Nov 14, 2025

Yes @ElenaGallo I confirm that's the expected behavior by default configuration. Please retest and improve the functional test scenario if necessary.

@ElenaGallo I just tested on dev and on stable, the CRS selector tool is visible based on the role of the user (see localConfig.json configuration make this plugin visible only for ADMIN role) Both dev and stable have the same behavior from my tests, could you please confirm the user roles used in the two screenshot #11492 (comment)?

thank you @allyoucanmap

@tdipisa
Copy link
Member

tdipisa commented Nov 18, 2025

@ElenaGallo can we finally mark this as accepted for both DEV and QA? The backport is not necessary here.

@ElenaGallo
Copy link
Contributor

@allyoucanmap For the Scale selector, on a small screen (e.g., 853×1280 px), the dropdown menu is not fully visible.

scale

@allyoucanmap
Copy link
Contributor

@ElenaGallo from the screenshot it seems you are using the device toolbar that simulate mobile devices. In MapStore you need to refresh the page to ensure it's detecting the correct device and related mobile configuration. After refreshing there isn't the map footer for mobile neither scale select input:

image

Instead if you are testing on desktop without the device toolbar and shrink the page width to 853px the scale input is correctly visible

image

A final note, the select input used is the native html select input and it could be rendered differently based on the device used. It seems the device simulation on the browser it's trying to use the default browser select functionality and fit it in the available space based also on the scale percentage applied, e.g.: if you are using 50% is fully visible:

image

In conclusion I don't think this is a bug because the scale input is not visible in mobile devices

@tdipisa
Copy link
Member

tdipisa commented Nov 19, 2025

Thank you @allyoucanmap. @ElenaGallo I moved back the issue in test. Please re-test.

@ElenaGallo
Copy link
Contributor

Hi @allyoucanmap, In my screenshot, the screen dimensions had already been updated and refer to the size of an iPad or similar device; this is why the scale selector is visible, but not fully displayed.
It is true that if I reduce the screen to 50%, the dropdown menu becomes fully visible.

ipad

@tdipisa In this case, can I move the issue to Accepted?

@tdipisa
Copy link
Member

tdipisa commented Nov 19, 2025

@ElenaGallo Normally in mobile devices the footer doesn't appear at all as expected by the default config.
With that kind of setup you are testing (Ipad Air and similar), a small fix is necessary, I think. However it is the same behavior we have in 2025.01.02. Please open a dedicated issue for this (no milestone for now, I will take care of it) and go ahead by marking this as accepted if the rest is ok.

@ElenaGallo
Copy link
Contributor

New issue here: #11703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor of MapFooter container layout

4 participants