Skip to content

Conversation

@rowheat02
Copy link
Contributor

@rowheat02 rowheat02 commented May 27, 2025

Description

New UI if multiple search services are available.
image

  • When hovering the mouse over "Search by location Name", new Sub menu container opens to pick the service

  • If the number of services takes more space than the limited height, then it is in scroll view.

  • The idea was dropped to search the services as it may give wrong meaning while selecting use all services option.
    image

  • All other options in the search bar will always be visible.

    image

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Enhancement

Issue

fixes #11139

What is the current behavior?

#11139

What is the new behavior?

Even if there are huge number of search services, no UI components will be hidden.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@rowheat02 rowheat02 added this to the 2025.01.00 milestone May 27, 2025
@rowheat02 rowheat02 self-assigned this May 27, 2025
@rowheat02 rowheat02 modified the milestones: 2025.01.00, 2025.01.01 May 27, 2025
@tdipisa tdipisa requested a review from dsuren1 May 27, 2025 12:24
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 27, 2025
Copy link
Contributor

@dsuren1 dsuren1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rowheat02
The functionality looks fine. Just a few minor amendments. Kindly have a look.

  • Move the tooltip placement on all services to the left, to be consistent with the other services in the list
    image
  • Please apply a pointer cursor when hovering over these search service menu items. Alternatively, consider using MenuItem instead of div to automatically apply the pointer cursor. Also, kindly ensure that the entire row displays the pointer on hover
    Screenshot 2025-05-28 at 3 45 17 PM

@rowheat02 rowheat02 requested a review from dsuren1 May 29, 2025 06:02
@rowheat02
Copy link
Contributor Author

rowheat02 commented May 29, 2025

@dsuren1 re-requested the review.

Please apply a pointer cursor when hovering over these search service menu items. Alternatively, consider using MenuItem instead of a div to automatically apply the pointer cursor. Also, kindly ensure that the entire row displays the pointer on hove

I avoided using the Menu item in the custom sub-menu container as the CSS was messed up when using MenuItem in a parent other than a dropdown. So, Div has been used, and the pointer cursor has been fixed in CSS.

@rowheat02
Copy link
Contributor Author

@dsuren1, tests have been fixed.

@dsuren1 dsuren1 enabled auto-merge (squash) May 29, 2025 08:12
@dsuren1 dsuren1 merged commit bb05e81 into geosolutions-it:master May 29, 2025
5 checks passed
@dsuren1
Copy link
Contributor

dsuren1 commented May 29, 2025

@ElenaGallo Kindly test this in DEV when available. Thanks!

rowheat02 added a commit to rowheat02/MapStore2 that referenced this pull request Jun 10, 2025
… configured geosolutions-it#11139 (geosolutions-it#11144)

* fix: new UI for multiple search services

* fix: updated requested changes

* fix: unit test fixes

* Update web/client/themes/default/less/searchbar.less

---------

Co-authored-by: Suren <dsuren1@gmail.com>
@ElenaGallo
Copy link
Contributor

Test passed, @rowheat02 please backport to 2025.01.xx. Thanks

tdipisa pushed a commit that referenced this pull request Jun 18, 2025
… configured #11139 (#11144) (#11182)

* fix: new UI for multiple search services

* fix: updated requested changes

* fix: unit test fixes

* Update web/client/themes/default/less/searchbar.less

---------

Co-authored-by: Suren <dsuren1@gmail.com>
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search service shows not all options due to amount of search services configured

4 participants