-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1095 changed modal layout for both on startup and empty results #1108
Conversation
saidaipparla
commented
Oct 10, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The grid of items should be responsive. Try to use the react-bootstrap's Grid system.
Now the grid is fixed, but you can make it configurable, with a good looking default
right: 200px; | ||
margin-top: 100px; | ||
display: inline-block; | ||
margin: 100PX; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not capital px. The style should be responsive (if the width of the window is smaller, it should be 0, for instance).
@@ -55,6 +55,7 @@ const MetadataExplorerComponent = React.createClass({ | |||
id: "mapstore-metadata-explorer", | |||
active: false, | |||
wrap: false, | |||
modal: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This have no effect, the modal parameter should be passed to the Dialog
component.
@simboss What do you think? In my opinion we should put on the same line CSW/WMS sekectir and the URL (at least for larger screens) |