Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1095 changed modal layout for both on startup and empty results #1108

Merged
merged 7 commits into from
Oct 11, 2016

Conversation

saidaipparla
Copy link
Contributor

catalog

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.584% when pulling 47f524f on catalog_window into b811c4a on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.584% when pulling 47f524f on catalog_window into b811c4a on master.

Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grid of items should be responsive. Try to use the react-bootstrap's Grid system.
Now the grid is fixed, but you can make it configurable, with a good looking default

http://react-bootstrap.github.io/components.html#grid

right: 200px;
margin-top: 100px;
display: inline-block;
margin: 100PX;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not capital px. The style should be responsive (if the width of the window is smaller, it should be 0, for instance).

@@ -55,6 +55,7 @@ const MetadataExplorerComponent = React.createClass({
id: "mapstore-metadata-explorer",
active: false,
wrap: false,
modal: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This have no effect, the modal parameter should be passed to the Dialog component.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 80.575% when pulling 60a3ec3 on catalog_window into b811c4a on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 80.554% when pulling a671a81 on catalog_window into b811c4a on master.

@saidaipparla
Copy link
Contributor Author

screenshots of final result
bigscreen
withresult
mapstore 2 homepage
screencapture-localhost-8081-1476175141360
screencapture-localhost-8081-1476175163910

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 80.563% when pulling 4737657 on catalog_window into b811c4a on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 80.563% when pulling 3543345 on catalog_window into b811c4a on master.

@offtherailz
Copy link
Member

@simboss What do you think? In my opinion we should put on the same line CSW/WMS sekectir and the URL (at least for larger screens)
Maybe we can make it smaller in wider screens.

@offtherailz offtherailz merged commit f0c5e6b into master Oct 11, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 80.457% when pulling 861d560 on catalog_window into 82e3c25 on master.

@offtherailz offtherailz deleted the catalog_window branch October 14, 2016 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants