#10262: Map (created with context) crashes if the export plugin is set up to be hidden to certain groups and the user is not logged in #10270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt plugin is set up to be hidden to certain groups and the user is not logged in Description: - edit parseExpression method in PluginUtils to handle the chanining within cfg expressions
1 task
…rt plugin is set up to be hidden to certain groups and the user is not logged in Description: - add unit test to test parseExpression change
MV88
approved these changes
May 2, 2024
|
@ElenaGallo please test it in DEV |
MV88
added
the
BackportNeeded
|
Test passed, @mahmoudadel54 please backport to 2024.01.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
May 9, 2024
…rt plugin is set up to be hidden to certain groups and the user is not logged in (geosolutions-it#10270) * geosolutions-it#10262: Map (created with context) crashes if the export plugin is set up to be hidden to certain groups and the user is not logged in Description: - edit parseExpression method in PluginUtils to handle the chanining within cfg expressions * geosolutions-it#10262: Map (created with context) crashes if the export plugin is set up to be hidden to certain groups and the user is not logged in Description: - add unit test to test parseExpression change
Backport is done ---> #10298 |
tdipisa
pushed a commit
that referenced
this pull request
May 10, 2024
…t up to be hidden to certain groups and the user is not logged in (#10270) (#10298) * #10262: Map (created with context) crashes if the export plugin is set up to be hidden to certain groups and the user is not logged in Description: - edit parseExpression method in PluginUtils to handle the chanining within cfg expressions * #10262: Map (created with context) crashes if the export plugin is set up to be hidden to certain groups and the user is not logged in Description: - add unit test to test parseExpression change
tdipisa
removed
the
BackportNeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I made an edit for parseExpression method in PluginUtils.js file to handle verifying the chaining if exists within cfg expressions
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10262
What is the current behavior?
#10262
What is the new behavior?
The map context works well without crashing in the case of #10262
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information