Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated methods in discretize for new ones #69

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

santisoler
Copy link
Member

@santisoler santisoler commented Nov 2, 2023

Replace the deprecated TensorMesh.getInterpolationMat method for TensorMesh.get_interpolation_matrix. Replace deprecated properties vol and cellGrad for cell_volumes and cell_gradient, respectively.

The usage of the deprecated methods leads to an error when trying to plot the potential, E and J fields.

Replace the deprecated `TensorMesh.getInterpolationMat` method for
`TensorMesh.get_interpolation_matrix`.
@santisoler
Copy link
Member Author

@lheagy, this is relevant for the DC/IP lab we are having next week. We should get it merged and update the version in the JupyterHub.

@santisoler santisoler changed the title Replace deprecated method in discretize for new one Replace deprecated methods in discretize for new ones Nov 2, 2023
@lheagy
Copy link
Member

lheagy commented Nov 3, 2023

Thanks @santisoler! I will test it out now. Did you check this against simpeg=0.19.0 ? this is what we are using for the environment on the hub https://github.com/geoscixyz/gpgLabs/blob/main/environment.yml

Copy link
Member

@lheagy lheagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @santisoler. Feel free to merge

@santisoler
Copy link
Member Author

Great! I'm merging it. And yes, I tested it with the same environment we are using on the hub.

@santisoler santisoler merged commit c8facfe into main Nov 3, 2023
16 of 20 checks passed
@santisoler santisoler deleted the fix-dc-deprecated-method branch November 3, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants