Bug fix: allow uppercase log filename in download_data.py #2508
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug where download_data.py failed if the dryrun log filename contained uppercase characters e.g. 'Log.dryrun'. The solution is to not coerce the dryrun log filename to lowercase.
yantosca
added
topic: Dry-Run Simulation
|
@yantosca updated the changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Ian Hough
Institution: Université Grenoble Alpes
Describe the update
Fixes a bug where
download_data.pyfails if the dryrun log filename contains uppercase characters e.g. 'Log.dryrun'. The solution is to not coerce the dryrun log filename to lowercase.Expected changes
No changes to model output
Reference(s)
None
Related Github Issue
#70