Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Add changes for SPI Bluetooth support. #60

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

peterharperuk
Copy link
Collaborator

See CYW43_ENABLE_BLUETOOTH.
New firmware added that supports Wifi and BT.
Firmware now stored as binary data in header files.

firmware/README.md Outdated Show resolved Hide resolved
firmware/README.md Outdated Show resolved Hide resolved
@peterharperuk peterharperuk force-pushed the bt_changes1 branch 2 times, most recently from 931b0ce to 8357297 Compare February 6, 2023 12:18
firmware/README.md Outdated Show resolved Hide resolved
src/cyw43.h Outdated Show resolved Hide resolved
src/cyw43_ctrl.c Outdated Show resolved Hide resolved
The new option CYW43_ENABLE_BLUETOOTH controls this new feature.

New firmware has been added that supports Wifi and BT.  The firmware is now
stored as binary data in C header files, to make it easier to include in a
project and its build system.
@dpgeorge dpgeorge merged commit 3c31d0b into georgerobotics:main Feb 7, 2023
@dpgeorge
Copy link

dpgeorge commented Feb 7, 2023

I've now merged this with the following minor changes (which were force pushed to this PR branch):

  • tweaked comments for new hci functions (changed "bt hci" to "Bluetooth HCI layer")
  • removed assert(false) from cyw43_ll_sdpcm_poll_device(), and assert(ret == 0) from cyw43_write_backplane_mem()
  • changed CYW43_PRINTF to CYW43_WARN in cyw43_write_backplane_mem()

Also in a follow-up commit I converted the remaining combined binary blob (for the Murata 1DX) to a header file.

@peterharperuk
Copy link
Collaborator Author

Thanks!

@Dirbaio
Copy link

Dirbaio commented Feb 8, 2023

👀 did you forget to add cyw43_btbus.c? or does something else provide the cyw43_btbus_init etc implementation, like pico-sdk?

@peterharperuk
Copy link
Collaborator Author

Yes. It'll be in the pico-sdk for the time being.

@Ferdi265 Ferdi265 mentioned this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants