-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust code refactor #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks very much! I will look through this when I get a chance. I am very much a C++ developer, this is my first attempt at any rust. So I am not surprised it's a bit of a mess! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uhh... It got out of hands, to be honest.
First of all, I love Toolbox. Great stuff, very well done.
I wanted to add some checks and stop randomly destroying my ears on bad configuration. Found some unconventional Rust code inside, so I started cleaning it up a bit; minor structure tweaks, little rusty abstractions, nothing exceptional. Ended up refactoring a big part of Filter's data model.
The change is kinda too big to review it all at once. Single commits are self-contained and mostly bite-sized, so it might be easier to review them instead. Also, feel free to cherry pick changes or deny these changes altogether; I understand it is kinda too much.
The program works as of last commit, and I tested it multiple times between commits. Still, I can't promise every single commit works, especially towards the later commits with bigger changes.
P.S.
cargo fmt
, Rust's default formatter, also had stuff to work on. Random formatting changes are on it. Please run it on your code regardless of this pull request, it's normally expected for Rust code to be formatted.