capture contact details on the database to be used in recordgeojson output #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvgenuchten
force-pushed
the
extend_recordgeojson
branch
5 times, most recently
from
a3cfd50 to
5146413
Compare
Member
|
Thank you @pvgenuchten for the PR. |
tomkralidis
requested changes
Nov 3, 2022
Member
tomkralidis
left a comment
tomkralidis
left a comment
There was a problem hiding this comment.
Great work @pvgenuchten. See change requests.
pvgenuchten
commented
Nov 4, 2022
pvgenuchten
force-pushed
the
extend_recordgeojson
branch
from
cd41dfb to
1adb436
Compare
tomkralidis
requested changes
Nov 21, 2022
pvgenuchten
force-pushed
the
extend_recordgeojson
branch
from
1adb436 to
7f2feb8
Compare
kalxas
approved these changes
Nov 24, 2022
Member
|
We need to test if the new field is populated properly when importing ISO-19115 XML |
tomkralidis
requested changes
Nov 25, 2022
Contributor
Author
I tested for iso, but not for others like dc |
pvgenuchten
force-pushed
the
extend_recordgeojson
branch
2 times, most recently
from
cc30d89 to
e59c57f
Compare
…y can be used on the ogcapi records recordgeojson output
pvgenuchten
force-pushed
the
extend_recordgeojson
branch
from
e59c57f to
50efaa9
Compare
pvgenuchten
force-pushed
the
extend_recordgeojson
branch
from
50efaa9 to
cc60fce
Compare
Contributor
Author
|
nice, this got merged, thanx for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a suggestion on how contact details can be captured on pycsw database, so they can be used on ogc-api-records.
It maps also topiccategory and otherconstraints to geojsonrecord properties (license and theme)
Related Issue / Discussion
#806
Additional Information
a new field 'contacts' has been added to the pycsw database
Contributions and Licensing