Skip to content

Prevent facets endpoint failure when facets are not configured #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sanjays2402 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent facets endpoint failure when facets are not configured #1245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pycsw/ogc/api/records.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ def facets_(self, headers_, args, collection='metadata:main'):
LOGGER.exception(msg)
return self.get_exception(400, headers_, 'InvalidParameterValue', msg)

for value in self.config['repository']['facets']:
for value in self.facets:
facets_[value] = {
'type': 'term',
'property': value,
Expand Down
11 changes: 11 additions & 0 deletions tests/functionaltests/suites/oarec/test_oarec_functional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,17 @@ def test_facets(config):
assert status == 400


def test_facets_not_configured(config):
config['repository'].pop('facets')

api = API(config)
headers, status, content = api.facets_({}, {})
content = json.loads(content)

assert status == 200
assert 'type' in content['facets']


def test_items(config):
api = API(config)
headers, status, content = api.items({}, None, {})
Expand Down