-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] remove shopt&alias to make it work on powershell #131
base: master
Are you sure you want to change the base?
[WIP] remove shopt&alias to make it work on powershell #131
Conversation
ae4fa34
to
fa0fc91
Compare
@tomkralidis, updated docs for powershell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, looks like these changes remove the alias and assume the command is docker compose
. This will break for students having docker-compose
installed (like me).
Best option is to make the script cross-platform. The $IsWindows
var e.g.
and https://redmondmag.com/articles/2020/08/18/cross-platform-powershell-scripts.aspx
ah, good to know people are still using docker-compose alternative would be to duplicate the script and rename to _ps.sh @justb4 PR updated |
fa0fc91
to
6426d43
Compare
syntax: bash geopython-workshop-ctl.sh start
6426d43
to
1b625d8
Compare
docker compose rm --force | ||
elif [ $1 == "url" ]; then | ||
# try to open the Jupyter Notebook in Browser | ||
platform="$(uname | tr '[:upper:]' '[:lower:]')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still required? I guess the openapp="cmd /c start"
is the command in PS here.
I cannot test this, but seems useful. I wonder if the |
PR to facilitate discussion on this topic
docker-compose was removed >1 year ago, i think we can assume all are migrated by now?
removing shopt and alias because it is not supported on powershell/windows
todo: update docs for windows:
syntax: bash geopython-workshop-ctl.sh start|stop|url|update