remove comments from xml, because it may fail parsing it #1025
+714
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@pvgenuchten issue or test case to demonstrate/reproduce the problem? |
Contributor
Author
|
Test case has been added (comment before md-identification, resolves #1026 <gmd:identificationInfo>
<!-- ## any comment here, fails the xml parsing, because the first element is taken, which is the comment ## -->
<srv:SV_ServiceIdentification uuid="a65c20b3-9f94-3bad-a307-a61021331d8c"> |
Contributor
Author
|
Not sure if comments are used by owslib anywhere, removed all of them in case similar code is used in other places causing this error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found an issue in a xml with a comment before srv:service-identification
suggestion to remove any comments before parsing
also added a new test case, pre (fails) and post (succeeds) PR