Skip to content

Conversation

@tomkralidis
Copy link
Member

Fixes #1010

@tomkralidis
Copy link
Member Author

FYI CI failures are unrelated to this PR.

@geographika
Copy link
Contributor

Thanks @tomkralidis.

Looks like CI is failing due to (unrelated) http://34.67.197.57:8585 being offline. Used in

NODE_TEST_OK_URL = 'http://34.67.197.57:8585/sensorhub/test'
# Directs to OSH hosted test server

Was using a list for the identifier an error (I presume so as it is no longer supported)?

@tomkralidis
Copy link
Member Author

Was using a list for the identifier an error (I presume so as it is no longer supported)?

It was for downstream applications passing identifier as a str in getCoverage. The PR removes the ambiguity.

@geographika
Copy link
Contributor

Was using a list for the identifier an error (I presume so as it is no longer supported)?

It was for downstream applications passing identifier as a str in getCoverage. The PR removes the ambiguity.

Ok. +1 for merging, but as this will break existing user code, I guess we should bump the version to 0.36.0.

@tomkralidis
Copy link
Member Author

Ok. +1 for merging, but as this will break existing user code, I guess we should bump the version to 0.36.0.

Yes, +1 on next release.

@tomkralidis tomkralidis merged commit 65a6bf9 into master Sep 17, 2025
0 of 6 checks passed
@tomkralidis tomkralidis deleted the issue-1010 branch September 17, 2025 20:06
@tomkralidis
Copy link
Member Author

Looks like CI is failing due to (unrelated) http://34.67.197.57:8585 being offline. Used in

NODE_TEST_OK_URL = 'http://34.67.197.57:8585/sensorhub/test'
# Directs to OSH hosted test server

Dedicated issue opened in #1013.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Passing an identifier string (not in a list) silently truncates it

3 participants