Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use new schematic channels #177

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

feat: use new schematic channels #177

wants to merge 9 commits into from

Conversation

oterral
Copy link
Collaborator

@oterral oterral commented Oct 14, 2022 •
edited
Loading

How to

This PR allow using schamtich channel using a specific tenant.

This changes has been postpone for next year.

Others

  • It's not a hack or at least an unauthorized hack :).
  • The images added are optimized.
  • Everything in ticket description has been fixed.
  • The author of the MR has made its own review before assigning the reviewer.
  • The title means something for a human being and follows the conventional commits specification.
  • The title contains [WIP] if it's necessary.
  • Labels applied. if it's a release? a hotfix?
  • The new class' members & methods are well documented
  • Tests added.

@oterral oterral self-assigned this Oct 14, 2022
@oterral oterral requested a review from danji90 October 14, 2022 06:33
@vercel
Copy link

vercel bot commented Oct 14, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
mobility-toolbox-js ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 9, 2023 at 7:44AM (UTC)

danji90
danji90 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@danji90 danji90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to review so I guess LGTM

@oterral oterral marked this pull request as draft November 16, 2022 13:55
@oterral oterral changed the title chore: new schematic channel feature: use new schematic channels Nov 16, 2022
@oterral oterral changed the title feature: use new schematic channels feat: use new schematic channels Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danji90 danji90 danji90 approved these changes

Assignees

@oterral oterral

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oterral @danji90