Consolidate wheel building workflows in a single file #61
Conversation
|
I now created a single job for the wheel building, but since the linux (docker) vs mac/windows are more different, I could also define two jobs: one for linux and one for mac/windows, and then have the test job depend on both those jobs. As a next step, we will also need to move this to the release workflow, because we want to have the release step depend on the wheels (needs the artifacts to upload and depends on successful tests) |
jorisvandenbossche
force-pushed
the
consolidate-wheel-building
branch
from
23d848b
to
73d97c6
Compare
|
Thanks for working on this!
I like this idea; it seems like it would help avoid some of the conditional logic that is in the single job. |
There was a problem hiding this comment.
This looks great - thank you so much for working on this @jorisvandenbossche !
| @@ -49,4 +49,4 @@ GDAL_INCLUDE_PATH = "$VCPKG_INSTALL/include" | |||
| GDAL_LIBRARY_PATH = "$VCPKG_INSTALL/lib" | |||
| PYOGRIO_PACKAGE_DATA = 1 | |||
| GDAL_DATA = "$VCPKG_INSTALL/share/gdal" | |||
| PROJ_LIB = "$VCPKG_INSTALL/share/proj4" | |||
| PROJ_LIB = "$VCPKG_INSTALL/share/proj/data" | |||
There was a problem hiding this comment.
This change was needed because of microsoft/vcpkg#23186
Follow-up on #55