-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add support to read, write, list and remove /vsimem/
files
#457
ENH: add support to read, write, list and remove /vsimem/
files
#457
Conversation
Most likely this, though probably wasn't going to prioritize fixing it unless there was a need (apparently there is). |
/vsimem/
files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @theroggy and apologies for the slow review! I only had a chance to review up to your tests and will try to review those in the next couple of days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments, thanks for the updates so far @theroggy , and thanks for your patience with the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I think it can be done in a later PR (but preferably for 0.10.0), but we should probably document how the |
…e-to-use-/vsimem-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theroggy ! @jorisvandenbossche any final comments or disagreement with the plan to add the vsi_*
functions at the top-level for now?
Add support for the basic operations on /vsimem/ files: read, write, list and remove.
TODO:
Triggered by a topic in the "discussion" section of geopandas, where someone noted that pre-geopandas 1.0 this worked and now it does not anymore: geopandas/geopandas#3376
<-- clarified below
I now noticed the following statement in: #407
@brendan-ward I wonder... is this meant as:
-->