TST/CLN: Replace all tmpdir / os.path operations in tests with pathlib.Path #411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #400
This removes all instances of the legacy pytest
tmpdir
fixture, and uses thetmp_path
(a pathlib.Path object) fixture instead.Modernized the various path operations in the tests to use methods on the pathlib.Path object.
Removes unused
win32.py
test file; we have actual tests against windows and this is no longer used.Note: I updated the benchmarks to use
tmp_path
and verified that most of them still run (some fail with missing test files), but we're not actively maintaining these.