Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: avoid/reduce unimportant warnings in tests #363

Merged

Conversation

theroggy
Copy link
Member

No description provided.

@theroggy theroggy marked this pull request as draft February 25, 2024 09:47
@theroggy theroggy marked this pull request as ready for review February 25, 2024 12:13
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

pyogrio/tests/test_geopandas_io.py Outdated Show resolved Hide resolved
pyogrio/tests/test_core.py Outdated Show resolved Hide resolved
@theroggy
Copy link
Member Author

theroggy commented Feb 26, 2024

It looks like some changes got mixed up with PR #362. Cleaned up.

@brendan-ward brendan-ward added this to the 0.8.0 milestone Feb 28, 2024
@jorisvandenbossche jorisvandenbossche merged commit b114b93 into geopandas:main Mar 4, 2024
19 checks passed
@jorisvandenbossche
Copy link
Member

Thanks!

@theroggy theroggy deleted the TST-reduce-warnings-in-tests branch March 4, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants