ENH: Add support for detecting write drivers using GDAL #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #220
Supersedes #268
This adds support to use GDAL directly to detect supported write drivers based on a path, instead of using the hard-coded list we had previously.
This moves the
detect_driver
function to core; we may want to expose this as part of the public API for use in GeoPandas but I did not yet do so (let me know if this is a good idea).As part of this, I had to rearrange a few things that are not part of the public API:
_preprocess_options_key_value
moved toutil.py
to avoid a circular import issue; it is more utility-oriented anywayDRIVERS
was moved to the testing side, which is the only other place we were using it directly besides extension to driver detection. This wasn't part of the official public API, so hopefully this is not a breaking change, but we can mention it in the changelog if you think appropriate.