ENH: add get_gdal_data_path to query GDAL data directory #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
changed the title
| ------- | ||
| str, or None if data directory was not found | ||
| """ | ||
| return _get_gdal_data_path() |
There was a problem hiding this comment.
I took this approach of wrapping into another function to mimic what we did for get/set_gdal_config_option (although it seems a bit superfluous)
brendan-ward
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Thanks @jorisvandenbossche
Should this go into 0.4.1 (still pending a fix for the release failures) or wait for 0.5 (which should include #155 and other new big features)? Either way, would you mind adding a changelog entry?
|
Since it's only a tiny helper function, I suppose it can be included in 0.4.2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159
I made the small function I tested when commenting about this on the geopandas repo into a PR.