CI: Fix minimal test env and remove deps on pandas / geopandas #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pyogrio.write_dataframe(gdf, dst_path) | ||
| meta["spatial_index"] = False | ||
| # allow mixed Polygons/MultiPolygons type | ||
| meta["geometry_type"] = "Unknown" |
There was a problem hiding this comment.
This one line is a change compared to what was there before? Or did write_dataframe infer such a geometry type? (I would have expected that it would infer "MultiPolgyon" and set promote_to_multi to true)
There was a problem hiding this comment.
The detection and promotion happens in write_geodataframe and doesn't happen in the case of the raw write.
With a little bit of refactoring we could move that into write instead (I think this was even suggested when that was first added), but I didn't think we needed to do so prior to 0.4 (changes noted in the changelog are specific to GeoDataFrame)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #132 (thanks @jorisvandenbossche !)
Cleans up a dependency on pandas outside of our try / catch block for GeoPandas, and uses raw IO methods for preparing test files instead of geopandas