Add --no-use-pep517 to get around pip oldest-supported-numpy issue #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/docker-gdal.yml
Outdated
| @@ -34,7 +34,7 @@ jobs: | |||
| run: | | |||
| python3 -m pip install --no-cache-dir -U pip wheel | |||
| python3 -m pip install --no-cache-dir cython~=0.29 | |||
| python3 -m pip install --no-cache-dir --no-build-isolation -e .[dev,test,geopandas] | |||
| python3 -m pip install --no-cache-dir --no-build-isolation --no-use-pep517 -e .[dev,test,geopandas] | |||
There was a problem hiding this comment.
Alternatively, we could also remove the --no-build-isolation altogether and test the default pip installation in this workflow (and then we can also remove the cython install step on the line above)
There was a problem hiding this comment.
Yeah, that's cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #107
As I understand it, a recent pip upgrade now runs into issues with
oldest-supported-numpydeclared inpyproject.tomlwhen running with--no-build-isolationwhennumpyisn't yet installed. The fix is to add--no-use-pep517.This updates to do the same thing as pandas: pandas-dev/pandas#47015