Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto detection of driver for .geojson, .geojsonl and .geojsons files #101

Merged
merged 9 commits into from
May 18, 2022
Merged

Add auto detection of driver for .geojson, .geojsonl and .geojsons files #101

merged 9 commits into from
May 18, 2022

Conversation

theroggy
Copy link
Member

@theroggy theroggy commented May 11, 2022 •
edited
Loading

+ add to file formats that should be tested.

Issue found: writing empty file to .geojsons is appartently not supported: logged here: #94

@theroggy theroggy mentioned this pull request May 11, 2022
Merged
@brendan-ward brendan-ward mentioned this pull request May 11, 2022
Open
@theroggy theroggy changed the title Add auto detection of driver for .geojson and .geojsons files Add auto detection of driver for .geojson, .geojsonl and .geojsons files May 12, 2022
jorisvandenbossche
jorisvandenbossche reviewed May 14, 2022
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pyogrio/tests/conftest.py Outdated Show resolved Hide resolved
@brendan-ward
Copy link
Member

It looks like parts of this are superseded by changes in #75? Except test_autodetect_driver?

@theroggy
Copy link
Member Author

It looks like parts of this are superseded by changes in #75? Except test_autodetect_driver?

Yes, Joris suggested to put this in a seperate PR as it is unrelated to #75.

jorisvandenbossche
jorisvandenbossche reviewed May 17, 2022
View reviewed changes
pyogrio/tests/test_raw_io.py Outdated Show resolved Hide resolved
pyogrio/tests/test_raw_io.py Outdated Show resolved Hide resolved
jorisvandenbossche
jorisvandenbossche approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorisvandenbossche jorisvandenbossche merged commit 6ee7f15 into geopandas:main May 18, 2022
@theroggy theroggy deleted the Writing-empty-.geojsons-is-not-supported-test- branch May 18, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theroggy @brendan-ward @jorisvandenbossche