Skip to content

CI: update use of deprecated iteritems to avoid warnings #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2022

Conversation

m-richards
Copy link
Member

@m-richards m-richards commented Jan 22, 2022

Should fix the failing 310-dev environment, we're just now getting warnings from pandas-dev/pandas#45321

(the change in geoseries is not required to fix CI, but seemed sensible to get all at once)

I also noticed setting up a local environment that this environment doesn't actually seem to use numpy main, despite in being in the yaml:

- --pre --extra-index https://pypi.anaconda.org/scipy-wheels-nightly/simple numpy

I'll make that a separate issue though.

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorisvandenbossche jorisvandenbossche merged commit ae4fe4d into geopandas:main Jan 23, 2022
@m-richards m-richards deleted the fix_ci branch January 23, 2022 10:02
@d3netxer
Copy link

The docs still list iteritems(), I made me think it was not depreciated.

https://geopandas.org/en/stable/docs/reference/api/geopandas.GeoSeries.html

@m-richards
Copy link
Member Author

Hi @d3netxer, I think it's still expected that this should be listed in the docs - it hasn't been removed yet. In principle we could add a deprecation warning/ hide this method, but it's a little tricky to do in practice as that list of methods is auto-generated and iteritems itself is inherited from pandas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants