Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hypersphere space small improvements #142

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Hypersphere space small improvements #142

merged 2 commits into from
Aug 13, 2024

Conversation

vabor112
Copy link
Member

@vabor112 vabor112 commented Aug 6, 2024

No description provided.

stoprightthere
stoprightthere approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@stoprightthere stoprightthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need to rename n to J. If anything, I'd rename J to M in the comment that explains the shape (IIRC we use M for the number of eigenfunctions elsewhere).

Other than that LGTM

@vabor112
Copy link
Member Author

The number of eigenfunctions is J everywhere since the large pre-0.2-release refactoring. So I just changed it in Hypersphere for consistency, because I forgot to do it before.

@vabor112 vabor112 merged commit 8f918cc into main Aug 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoprightthere stoprightthere stoprightthere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vabor112 @stoprightthere