Skip to content

fix: Draw.Rectangle should use the same code to get the corners as Edit.Rectangle #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2023
Merged

fix: Draw.Rectangle should use the same code to get the corners as Edit.Rectangle #1373

merged 3 commits into from
Nov 21, 2023

Conversation

AlimurtuzaCodes
Copy link
Contributor

@AlimurtuzaCodes AlimurtuzaCodes commented Jun 27, 2023 •
edited
Loading

What does this PR do

Followed two steps as mentioned in the issue.

  • Update _findCorners in Draw.Rectangle
  • add rectangleAngle: 0 to the default Draw options: src/js/Draw/L.PM.Draw.js

Fixed Draw.Rectangle file in leaflet-geoman/src/js/Draw/L.PM.Draw.Rectangle.js

Issue Number- #1369

@AlimurtuzaCodes AlimurtuzaCodes mentioned this pull request Jun 27, 2023
Closed
2 tasks
@Falke-Design
Copy link
Collaborator

Thank you for creating this PR. Do you think you are able to add a test for it too?

@Falke-Design Falke-Design linked an issue Jul 8, 2023 that may be closed by this pull request
Draw.Rectangle should use the same code to get the corners as Edit.Rectangle #1369
Closed
2 tasks
@AlimurtuzaCodes
Copy link
Contributor Author

Thank you for creating this PR. Do you think you are able to add a test for it too?

I won't be able to add a test for this.

@Falke-Design Falke-Design added this to the 2.15.0 milestone Nov 5, 2023
@codeofsumit codeofsumit merged commit 3a9a4a6 into geoman-io:develop Nov 21, 2023
@purplesecops purplesecops mentioned this pull request May 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Falke-Design Falke-Design Falke-Design approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

Draw.Rectangle should use the same code to get the corners as Edit.Rectangle

3 participants

@AlimurtuzaCodes @Falke-Design @codeofsumit